note.md : Updates

cwFlowNet.cpp

@@ -3649,6 +3649,9 @@ cw::rc_t cw::flow::exec_cycle( network_t& net )
 
   for(unsigned i=0; i<net.procN; ++i)
   {
+    
+    net.procA[i]->modVarRecurseFl = true;
+    
     // Call notify() on all variables marked for notification that have changed since the last exec_cycle()
     proc_notify(net.procA[i], kCallbackPnFl | kQuietPnFl);
 
@@ -3662,7 +3665,10 @@ cw::rc_t cw::flow::exec_cycle( network_t& net )
         rc = cwLogError(rc,"Execution failed on the proc:%s:%i.",cwStringNullGuard(net.procA[i]->label),net.procA[i]->label_sfx_id);
         break;
       }
-    }    
+    }
+    
+    net.procA[i]->modVarRecurseFl = false;
+    
   }
 
   return halt_fl ? ((unsigned)kEofRC) : rc;

cwFlowProc.cpp

@@ -1517,7 +1517,6 @@ namespace cw
         rc_t     rc           = kOkRC;
         const abuf_t* ibuf = nullptr;
         abuf_t*       obuf = nullptr;
-        inst_t*  inst = (inst_t*)(proc->userPtr);
 
         // get the src buffer
         if((rc = var_get(proc,kInPId, kAnyChIdx, ibuf )) != kOkRC )
@@ -5999,7 +5998,6 @@ namespace cw
           p->store_vid = kInvalidIdx;
         }
 
-      errLabel:
         return rc;
       }
 
@@ -6215,7 +6213,6 @@ namespace cw
           p->store_fl = false;
         }
 
-      errLabel:
         return rc;
       }
 
@@ -6371,7 +6368,6 @@ namespace cw
           var_set(proc,kOutPId,kAnyChIdx,!val);
         }
 
-      errLabel:
         return rc;
       }
 
@@ -7076,7 +7072,6 @@ namespace cw
           p->deltaFl = false;
         }
 
-      errLabel:
         return rc;
       }
 
@@ -8479,7 +8474,6 @@ namespace cw
       {
         rc_t rc      = kOkRC;
         abuf_t* outAudioBufA[ p->outVarN ];
-        unsigned out_var_idx;
 
         if( p->trigger_fl )
         {

cwFlowTypes.cpp

@@ -164,7 +164,7 @@ namespace cw
     rc_t _mod_var_map_update( variable_t* var )
     {
       rc_t rc = kOkRC;
-      if( cwIsFlag(var->varDesc->flags,kNotifyVarDescFl ) )
+      if( cwIsFlag(var->varDesc->flags,kNotifyVarDescFl ) && var->proc->modVarRecurseFl==false )
       {      
         // if the var is already modVarMapA[] then there is nothing to do
         // (use acquire to prevent rd/wr from moving before this op)
@@ -794,8 +794,7 @@ errLabel:
 cw::rc_t cw::flow::class_preset_has_var( const class_preset_t* class_preset, const char* var_label, bool& fl_ref )
 {
   rc_t rc = kOkRC;
-  const object_t* var_cfg;
-      
+  
   fl_ref = false;
 
   if( class_preset->cfg == nullptr )

cwFlowTypes.h

@@ -151,6 +151,7 @@ namespace cw
       unsigned        varMapN;       // varMapN = varMapIdN * varMapChN 
       variable_t**    varMapA;       // varMapA[ varMapN ] = allows fast lookup from ('vid','chIdx) to variable
 
+      bool                  modVarRecurseFl;  // flag used to prevent call to set_var() from inside _notify() from calling var_schedule_notification()
       variable_t**          modVarMapA;       // modVarMapA[ modVarMapN ]
       unsigned              modVarMapN;       // modVarMapN == varMapN
       unsigned              modVarMapTailIdx; // index of next full slot in varMapA[]

cwIo.cpp

@@ -2536,6 +2536,15 @@ cw::rc_t cw::io::stop( handle_t h )
   return rc;
 }
 
+bool cw::io::is_started_flag( handle_t h )
+{
+  if( h.isValid() )
+  {
+    io_t* p = _handleToPtr(h);
+    return p->startedFl.load();
+  }
+  return false;
+}
 
 cw::rc_t cw::io::exec( handle_t h, unsigned timeOutMs, void* execCbArg )
 {

cwIo.h

@@ -163,10 +163,12 @@ namespace cw
     
     rc_t destroy( handle_t& h );
 
+    
     rc_t start( handle_t h );
     rc_t pause( handle_t h );
     rc_t stop(  handle_t h );
 
+    bool is_started_flag( handle_t h );
 
     // Note that this call blocks on the the UI websocket handle for up to 'timeOutMs'.
     // See ui:ws:exec().

cwNbMpScQueue.cpp

@@ -98,8 +98,7 @@ namespace cw
           if( b->eleN.load(std::memory_order_acquire) <= 0 )
           {
             // decr. the cleanBlkN count
-            unsigned cc = p->cleanBlkN.fetch_add(-1,std::memory_order_relaxed);
-            assert(cc>=1);
+            assert( p->cleanBlkN.fetch_add(-1,std::memory_order_relaxed) >= 1);
 
             // Note: b->full_flag==true and p->eleN==0 so it is safe to reset the block
             // because all elements have been removed (eleN==0) and
@@ -336,10 +335,8 @@ cw::nbmpscq::blob_t cw::nbmpscq::advance( handle_t h )
     // first 'stub' will not have a valid block pointer
     if( t->block != nullptr )
     {
-      int eleN = t->block->eleN.fetch_add(-1,std::memory_order_acq_rel);
-    
       // next was valid and so eleN must be >= 1
-      assert( eleN >= 1 );
+      assert( t->block->eleN.fetch_add(-1,std::memory_order_acq_rel) >= 1 );
     }
     
   }

notes.md

@@ -977,7 +977,8 @@ a connected value - since they are implemented as pointers back to the source va
 
 - The 'two slot' approach to setting variable no longer seems useful.
 The only reason not to eliminate it is to possibly use it as a way to test local values
-before they are set, but it isn't clear if this actually useful.
+before they are set, but it isn't clear if this actually useful.  Consider the case
+of setting min/max for numeric values - could it be used there?
 
 
 - DONE: Allow proc's to send messages to the UI. Implementation: During exec() the proc builds a global list of variables whose values
@@ -1039,6 +1040,8 @@ Look at all the places `var_create()` is called can the value arg. be removed?
   initially applied - does that mean an uninitialized channel is just sitting there? (... no i think
   the previous channel is duplicated in var_channelize())
 
+- The IO system can use audio files as audio devices.  Document this!
+
 - UI Issues:
     + When UI appIdMap[] labels do not match ui.cfg labels no error is generated. All appIdMap[] labels should be
       validated to avoid this problem.
@@ -1054,7 +1057,7 @@ Look at all the places `var_create()` is called can the value arg. be removed?
 
     + mult proc's with more than 3 instances should be put into a list or use a 'disclose' button
 
-    + add a UI label to the var description, 
+    + add a UI label to the flow var description
 
 
 
@@ -1112,7 +1115,7 @@ Consider a network with a variable sample rate.
 
 - Implement user defined data types.
 
-- Implement matrix types.
+- Implement matrix types. ... pick a library.
 
 - Add a 'trigger' data type. The 'kAllTId' isn't really doing anything.
 Perhaps this  could be a 'symbol' data type?
@@ -1404,6 +1407,9 @@ multiple times during the cycle only the last value will be recorded.
 This limitation however exists for all processor input variables whether they
 use the notification scheme or not.
 
+Note that when the value of a variable that is marked for notification is changed
+inside the notify() callback of the proc with owns it a new notification will not be
+triggered.  A processor will never trigger a notification on any of it's own variables.
 
 Optional Variables
 -------------------